Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atomically package instead of write-file-atomic #115

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

jurepetrovic
Copy link
Contributor

@jurepetrovic jurepetrovic commented Jul 14, 2020

Use atomically instead of writeFileAtomic.

sindresorhus/electron-store#103

package.json Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
source/index.ts Outdated Show resolved Hide resolved
source/index.ts Outdated Show resolved Hide resolved
variable name changes.
cleanup for PR
@jurepetrovic
Copy link
Contributor Author

Ok, should be fine now.

@jurepetrovic
Copy link
Contributor Author

Please also release new NPM package if ok

@sindresorhus sindresorhus changed the title changed dependency to atomically instead of write-file-atomic Use atomically package instead of write-file-atomic Jul 17, 2020
@sindresorhus
Copy link
Owner

@jurepetrovic Tip for the future: Never do PRs from master branch.

@sindresorhus sindresorhus merged commit 6c624a0 into sindresorhus:master Jul 17, 2020
@jurepetrovic
Copy link
Contributor Author

@sindresorhus yes, figured that one out the hard way. Thanks ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants