Fix empty check #74
Closed
Fix empty check #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This causes the tests to fail: https://travis-ci.org/sindresorhus/cpy/jobs/650091952?utm_medium=notification&utm_source=github_status |
|
Okay; I fixed it, but this is likely irrelevant given @whitecrownclown's #75. |
|
Feel free to close this out if we're going with #75, but @whitecrownclown could I ask you to pull in the change per https://github.com/sindresorhus/cpy/pull/74/files#diff-1dd241c4cd3fd1dd89c570cee98b79ddR162 so that test case actually covers what it's supposed to? |
|
@taion Thanks, I've updated the PR with your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #50. The check and the test to not throw when globs were included was wrong, because the glob provided actually did match files.