feat: recursive copying with --up #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needed for sindresorhus/cpy-cli#33 |
sindresorhus
requested changes
Feb 27, 2022
index.d.ts
Outdated
|
|
||
| @default 0 | ||
| */ | ||
| readonly up?: boolean; |
There was a problem hiding this comment.
I don't think this is a good option name. Maybe trimPathComponents or something.
index.js
Outdated
| if ((path.normalize(source).split(path.sep).length - 1) < up) { | ||
| throw new Error('cant go up that far'); | ||
| } | ||
| return path.join(path.normalize(source).split(path.sep).slice(up)); |
index.js
Outdated
| if (!up) { | ||
| return source; | ||
| } | ||
| if (up === true) { |
There was a problem hiding this comment.
This case is not documented.
|
This will need tests. |
|
Note that things have changed since you started this: https://github.com/sindresorhus/cpy/releases/tag/v9.0.0 |
added 7 commits
March 16, 2022 13:38
Note that things have changed since you started this
tornadia
approved these changes
Mar 16, 2022
sindresorhus
requested changes
Mar 19, 2022
|
Sorry, been a bit busy. Gonna check em out and jump on it, thanks @sindresorhus Edit: changes commited! Thanks for your patience. |
sindresorhus
reviewed
May 2, 2023
| ``` | ||
|
|
||
| Where the destination paths of `*.js` files within subdirectories of the `src` directory | ||
| will be flattened to a reduced structure another `destination/flatSourceFiles` path. |
There was a problem hiding this comment.
Don't hard-wrap.
This is missing from index.d.ts
And I think it needs a rewrite. I don't really understand what it's trying to say.
StemmlerSisters
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.