Cjs globby v13 esm #140
Closed
Cjs globby v13 esm #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to globby 13.1.1 returns now Promise<string[]> not string[] so this upgrade is not even possible. without new Major version ## conclusion defer globby upgrade from 11 => 13 till ESM only version of del
Updated globby but that changes the output of the sync function so i bumped the minor version
Updated the typedef to reflect the minor api change
|
i close this as this is for review only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Issue this PR only to discusse that with you in issue #138
Conclusion
because of this pull request that changes the api of sync as it now would return a Promise<string[]>
Two choices