Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Typescript types for defaultActions #153

Open
oleg-slapdash opened this issue Nov 27, 2021 · 0 comments
Open

Incorrect Typescript types for defaultActions #153

oleg-slapdash opened this issue Nov 27, 2021 · 0 comments

Comments

@oleg-slapdash
Copy link

Typescript actions defined as

	interface Actions {
		readonly separator: () => MenuItemConstructorOptions;
		readonly learnSpelling: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly lookUpSelection: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly searchWithGoogle: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly cut: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly copy: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly paste: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly saveImage: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly saveImageAs: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly copyLink: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly copyImage: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly copyImageAddress: (options: ActionOptions) => MenuItemConstructorOptions;
		readonly inspect: () => MenuItemConstructorOptions;
		readonly services: () => MenuItemConstructorOptions;
	}

But in fact, the options argument has a default value. All actions should be defiend as:

	interface Actions {
		readonly separator: () => MenuItemConstructorOptions;
		readonly learnSpelling: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly lookUpSelection: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly searchWithGoogle: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly cut: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly copy: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly paste: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly saveImage: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly saveImageAs: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly copyLink: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly copyImage: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly copyImageAddress: (options?: ActionOptions) => MenuItemConstructorOptions;
		readonly inspect: () => MenuItemConstructorOptions;
		readonly services: () => MenuItemConstructorOptions;
	}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant