Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic search engine menu item #164

Closed

Commits on Sep 11, 2022

  1. add generic search engine option

    Squashed commits:
    
    [WIP] Simpler implementation of adding generic "Search with ..." menu item (search engine title and url provided by user). Still needs some tweaking
    
    [WIP] Ensure URLs copied from Chrome's available search engines work with this implementation
    
    [WIP] Update documentation, renaming option
    
    apply fixes indicated by XO
    
    Merge branch 'sindresorhus:main' into add-other-search-engine
    
    wording tweaks, clean ups to be more consistent
    
    simplify
    
    more tweaks
    
    more tweaks
    
    reword
    
    use tabs instead of spaces for example (shows up in readme with refined github)
    
    properly handle case when addSearchWithOther option is not set
    
    add a "control" test where no options are set to ensure default scenario is working
    
    Revert "add a "control" test where no options are set to ensure default scenario is working"
    
    This reverts commit 39d8512.
    
    fix casing
    
    more doc tweaks
    
    missed rewording
    
    simplify @Property items
    
    * move length check of addSearchWithOther closer to undefined check (confused when revisiting after awhile) * update ts types file to match readme's property section * fix whitespaces
    
    more tweaks
    
    fix XO trailing space errors
    
    add types for addSearchWithOther properties
    hns258 committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    53a6837 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Configuration menu
    Copy the full SHA
    6d80556 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. clean up, tweaks

    hns258 committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e934d0e View commit details
    Browse the repository at this point in the history