Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native Linux implementation in .showAboutWindow() #16

Merged
merged 2 commits into from Jun 15, 2019
Merged

Use native Linux implementation in .showAboutWindow() #16

merged 2 commits into from Jun 15, 2019

Conversation

codebytere
Copy link
Contributor

Updates showAboutWindow to use native about panel on Linux, which was made available in Electron via this PR starting in Electron v5.0.0.

@sindresorhus
Copy link
Owner

You need to update the TypeScript definition too.

Thanks for doing this :)

@sindresorhus sindresorhus changed the title Update showAboutWindow for native Linux impl Use native Linux implementation in .showAboutWindow() Jun 6, 2019
@codebytere
Copy link
Contributor Author

@sindresorhus i think that should be everything 🚀

@sindresorhus sindresorhus merged commit 9b5158c into sindresorhus:master Jun 15, 2019
@sindresorhus
Copy link
Owner

Looks good :)

@mquevill mquevill mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @sindresorhus