fix: use ./ syntax for exporting a package name export #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
else we got "Cannot find module 'electron-util/main' or its corresponding type declarations." error
benoitf
added a commit
to benoitf/desktop
that referenced
this pull request
Feb 26, 2024
for main import, need to use a suffix also was requiring sindresorhus/electron-util#61 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
1 task
benoitf
added a commit
to benoitf/desktop
that referenced
this pull request
Feb 26, 2024
for main import, need to use a suffix also was requiring sindresorhus/electron-util#61 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
added a commit
to benoitf/desktop
that referenced
this pull request
Feb 26, 2024
for main import, need to use a suffix also was requiring sindresorhus/electron-util#61 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
added a commit
to containers/podman-desktop
that referenced
this pull request
Feb 28, 2024
for main import, need to use a suffix also was requiring sindresorhus/electron-util#61 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to upgrade from 0.17.2 to 0.18.0 in a project already using esm and electron 28+ but I got errors while importing
was reporting
Cannot find module 'electron-util/main' or its corresponding type declarations.erroradding the
./prefix is allowing me to have the documented syntax working