Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement listener subscription as async iterator protocol #20

Closed
wants to merge 25 commits into from
Closed

Implement listener subscription as async iterator protocol #20

wants to merge 25 commits into from

Commits on Jan 2, 2018

  1. feat: register event listener with asynchronous iterator protocol - c… 

    …lose #3
    @lorenzofox3
    lorenzofox3 committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    5656357 View commit details
    Browse the repository at this point in the history

  2. keep single line block formatting

    @lorenzofox3
    lorenzofox3 committed Jan 2, 2018
    Configuration menu
    Copy the full SHA
    78cbcd6 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2018

  1. fix xo and test setting

    @lorenzofox3
    lorenzofox3 committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    b50ec91 View commit details
    Browse the repository at this point in the history

  2. enable xo

    @lorenzofox3
    lorenzofox3 committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    c904739 View commit details
    Browse the repository at this point in the history

  3. removed useless eslint flag comments

    @lorenzofox3
    lorenzofox3 committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    c951511 View commit details
    Browse the repository at this point in the history

  4. split async iterator behavior to different file

    @lorenzofox3
    lorenzofox3 committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    d9b617a View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. Revert "split async iterator behavior to different file" 

    This reverts commit d9b617a.
    @novemberborn
    novemberborn committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    cac49ab View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/20

    @novemberborn
    novemberborn committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    ade1383 View commit details
    Browse the repository at this point in the history

  3. Implement async iterator protocol without generators, fix tests

    @novemberborn
    novemberborn committed Jan 4, 2018
    Configuration menu
    Copy the full SHA
    a4d414d View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2018

  1. Fix linting error

    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    a6a3476 View commit details
    Browse the repository at this point in the history

  2. Simplify next() implementation

    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    e91559c View commit details
    Browse the repository at this point in the history

  3. Handle edge case where return() is called by an earlier listener for … 

    …the same event

This clears 'queue' before the iterator pushes to it, which shouldn't cause a crash.
    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    c4ca867 View commit details
    Browse the repository at this point in the history

  4. Implement return() according to spec

    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    e18c260 View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary tsconfig files in test fixtures

    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    edb7ac5 View commit details
    Browse the repository at this point in the history

  6. Change how TypeScript is loaded in types test

    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    756b47a View commit details
    Browse the repository at this point in the history

  7. Return async iterator from .events(), not .on() 

    Add to TS definition and README.
    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    7ef2983 View commit details
    Browse the repository at this point in the history

  8. Implement .anyEvent()

    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    463c4e6 View commit details
    Browse the repository at this point in the history

  9. Tweak AVA's Babel options

    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    3f9aa37 View commit details
    Browse the repository at this point in the history

  10. Support running tests without for-await-of transpilation 

    Feature-detect for-await-of support, and only transpile this feature
when necessary.

With Node.js 9 you can use the following to run tests with the native
implementation:

```console
$ node --harmony_async_iteration ./node_modules/.bin/ava
```
    @novemberborn
    novemberborn committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    ef596e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2018

  1. Fix for-await transpilation 

    This syntax is transformed using async-to-generator, not async-generator-functions.
    @novemberborn
    novemberborn committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    361cddd View commit details
    Browse the repository at this point in the history

  2. Ensure async iterators return non-promise values 

    Follows https://tc39.github.io/proposal-async-iteration/#sec-asynciterator-interface
    @novemberborn
    novemberborn committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    735ee10 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2018

  1. Merge branch 'master' into pr/20

    @novemberborn
    novemberborn committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    6d73663 View commit details
    Browse the repository at this point in the history

  2. Tweak iterator implementation now that scheduling is more consistent

    @novemberborn
    novemberborn committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    0afc521 View commit details
    Browse the repository at this point in the history

  3. Remove wrongly placed documentation

    @novemberborn
    novemberborn committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    4cdcd6f View commit details
    Browse the repository at this point in the history

  4. Separate iterator production 

    clearListeners() now signals iterators to not expect further items,
without clearing the current queue.

Clarify that clearListeners() also impacts iterators. Similarly include
the number of active iterators in listenerCount().

Enqueue new iterator items synchronously, before listeners are called.
    @novemberborn
    novemberborn committed Jan 20, 2018
    Configuration menu
    Copy the full SHA
    94f54c0 View commit details
    Browse the repository at this point in the history