visualizeRuleTester: Support options (#840)

sindresorhus · Sep 29, 2020 · 2105707 · 2105707
1 parent 18bb3a3
commit 2105707
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 22 deletions.
diff --git a/test/explicit-length-check.js b/test/explicit-length-check.js
@@ -182,18 +182,17 @@ ruleTester.run('explicit-length-check', rule, {
 const visualizeTester = visualizeRuleTester(test);
 visualizeTester.run('explicit-length-check', rule, [
 	'if ([].length) {}',
-	'if (array.length < 1) {}'
-	// `visualizeRuleTester` don't support options
-	// {
-	// 	code: 'if (array.length > 0) {}',
-	// 	options: ['not-equal']
-	// },
-	// {
-	// 	code: 'if (array.length != 0) {}',
-	// 	options: ['greater-than']
-	// },
-	// {
-	// 	code: 'if (array.length != 0) {}',
-	// 	options: ['greater-than-or-equal']
-	// }
+	'if (array.length < 1) {}',
+	{
+		code: 'if (array.length > 0) {}',
+		options: [{'non-zero': 'not-equal'}]
+	},
+	{
+		code: 'if (array.length != 0) {}',
+		options: [{'non-zero': 'greater-than'}]
+	},
+	{
+		code: 'if (array.length != 0) {}',
+		options: [{'non-zero': 'greater-than-or-equal'}]
+	}
 ]);
diff --git a/test/snapshots/explicit-length-check.js.md b/test/snapshots/explicit-length-check.js.md
@@ -21,3 +21,30 @@ Generated by [AVA](https://avajs.dev).
     > 1 | if (array.length < 1) {}␊
         |     ^^^^^^^^^^^^^^^^ Zero `.length` should be compared with `=== 0`.␊
     `
+
+## explicit-length-check - #3
+
+> Snapshot 1
+
+    `␊
+    > 1 | if (array.length > 0) {}␊
+        |     ^^^^^^^^^^^^^^^^ Non-zero `.length` should be compared with `!== 0`.␊
+    `
+
+## explicit-length-check - #4
+
+> Snapshot 1
+
+    `␊
+    > 1 | if (array.length != 0) {}␊
+        |     ^^^^^^^^^^^^^^^^^ Non-zero `.length` should be compared with `> 0`.␊
+    `
+
+## explicit-length-check - #5
+
+> Snapshot 1
+
+    `␊
+    > 1 | if (array.length != 0) {}␊
+        |     ^^^^^^^^^^^^^^^^^ Non-zero `.length` should be compared with `>= 1`.␊
+    `
diff --git a/test/snapshots/explicit-length-check.js.snap b/test/snapshots/explicit-length-check.js.snap
diff --git a/test/utils/visualize-rule-tester.js b/test/utils/visualize-rule-tester.js
@@ -33,6 +33,13 @@ function visualizeEslintResult(text, result) {
 	return `\n${visualizeRange(text, location, message)}\n`;
 }
 
+const getVerifyConfig = (ruleId, testerConfig, options) => ({
+	...testerConfig,
+	rules: {
+		[ruleId]: ['error', ...(Array.isArray(options) ? options : [])]
+	}
+});
+
 class VisualizeRuleTester {
 	constructor(test, config) {
 		this.test = test;
@@ -42,16 +49,12 @@ class VisualizeRuleTester {
 	run(ruleId, rule, tests) {
 		const {test, config} = this;
 		const linter = new Linter();
-		const verifyConfig = {
-			...config,
-			rules: {
-				[ruleId]: 'error'
-			}
-		};
-
 		linter.defineRule(ruleId, rule);
 
-		for (const [index, code] of tests.entries()) {
+		for (const [index, testCase] of tests.entries()) {
+			const {code, options} = typeof testCase === 'string' ? {code: testCase} : testCase;
+			const verifyConfig = getVerifyConfig(ruleId, config, options);
+
 			test(`${ruleId} - #${index + 1}`, t => {
 				const results = linter.verify(code, verifyConfig);