Use in better-regex

sindresorhus · May 12, 2023 · 45af5cd · 45af5cd
1 parent ea862e0
commit 45af5cd
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/rules/better-regex.js b/rules/better-regex.js
@@ -3,7 +3,7 @@ const cleanRegexp = require('clean-regexp');
 const {optimize} = require('regexp-tree');
 const escapeString = require('./utils/escape-string.js');
 const {newExpressionSelector} = require('./selectors/index.js');
-const {isStringLiteral} = require('./ast/index.js');
+const {isStringLiteral, isNewExpression} = require('./ast/index.js');
 
 const MESSAGE_ID = 'better-regex';
 const MESSAGE_ID_PARSE_ERROR = 'better-regex/parse-error';
@@ -12,8 +12,6 @@ const messages = {
 	[MESSAGE_ID_PARSE_ERROR]: 'Problem parsing {{original}}: {{error}}',
 };
 
-const newRegExp = newExpressionSelector({name: 'RegExp', minimumArguments: 1});
-
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
 	const {sortCharacterClasses} = context.options[0] || {};
@@ -80,7 +78,11 @@ const create = context => {
 				fix: fixer => fixer.replaceText(node, optimized),
 			});
 		},
-		[newRegExp](node) {
+		NewExpression(node) {
+			if (!isNewExpression(node, {name: 'RegExp', minimumArguments: 1})) {
+				return;
+			}
+
 			const [patternNode, flagsNode] = node.arguments;
 
 			if (!isStringLiteral(patternNode)) {