no-abusive-eslint-disable: Refactor tests (#845)

rules/no-abusive-eslint-disable.js

@@ -19,6 +19,8 @@ const create = context => ({
 				!result.groups.ruleId // But it did not specify any rules
 			) {
 				context.report({
+					// Can't set it at the given location as the warning
+					// will be ignored due to the disable comment
 					loc: {
 						start: {
 							...comment.loc.start,

test/no-abusive-eslint-disable.js

@@ -11,20 +11,14 @@ const ruleTester = avaRuleTester(test, {
 });
 
 // Define rules for test
-[
+for (const rule of [
 	'plugin/rule',
 	'@scope/plugin/rule-name',
 	'@scope/rule-name',
 	'@scopewithoutplugin'
-].forEach(rule => {
+]) {
 	ruleTester.linter.defineRule(rule, {});
-});
-
-const error = [
-	{
-		messageId: 'no-abusive-eslint-disable'
-	}
-];
+}
 
 ruleTester.run('no-abusive-eslint-disable', rule, {
 	valid: [
@@ -65,37 +59,35 @@ ruleTester.run('no-abusive-eslint-disable', rule, {
 	],
 	invalid: [
 		{
-			code: 'eval(); // eslint-disable-line',
-			errors: error
-		},
-		{
-			code: 'foo();\neval(); // eslint-disable-line',
-			errors: error
-		},
-		{
-			code: '/* eslint-disable */',
-			errors: error
-		},
-		{
-			code: 'foo();\n/* eslint-disable */\neval();',
-			errors: error
-		},
-		{
-			code: 'foo();\n/* eslint-disable-next-line */\neval();',
-			errors: error
-		},
-		{
-			code: '// eslint-disable-next-line\neval();',
-			errors: error
-		},
-		{
-			code: '// eslint-disable-next-line @scopewithoutplugin\neval();',
-			errors: error
+			code: outdent`
+				// eslint-disable-next-line @scopewithoutplugin
+				eval();
+			`,
+			errors: 1
 		}
 	]
 });
 
 const visualizeTester = visualizeRuleTester(test);
 visualizeTester.run('no-abusive-eslint-disable', rule, [
-	'eval(); // eslint-disable-line'
+	'eval(); // eslint-disable-line',
+	outdent`
+		foo();
+		eval(); // eslint-disable-line
+	`,
+	'/* eslint-disable */',
+	outdent`
+		foo();
+		/* eslint-disable */
+		eval();
+	`,
+	outdent`
+		foo();
+			/* eslint-disable-next-line */
+				eval();
+	`,
+	outdent`
+		// eslint-disable-next-line
+		eval();
+	`
 ]);

test/snapshots/no-abusive-eslint-disable.js.md

@@ -13,3 +13,59 @@ Generated by [AVA](https://avajs.dev).
     > 1 | eval(); // eslint-disable-line␊
         | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Specify the rules you want to disable.␊
     `
+
+## no-abusive-eslint-disable - #2
+
+> Snapshot 1
+
+    `␊
+    Error 1/1:␊
+      1 | foo();␊
+    > 2 | eval(); // eslint-disable-line␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Specify the rules you want to disable.␊
+    `
+
+## no-abusive-eslint-disable - #3
+
+> Snapshot 1
+
+    `␊
+    Error 1/1:␊
+    > 1 | /* eslint-disable */␊
+        | ^^^^^^^^^^^^^^^^^^^^^ Specify the rules you want to disable.␊
+    `
+
+## no-abusive-eslint-disable - #4
+
+> Snapshot 1
+
+    `␊
+    Error 1/1:␊
+      1 | foo();␊
+    > 2 | /* eslint-disable */␊
+        | ^^^^^^^^^^^^^^^^^^^^^ Specify the rules you want to disable.␊
+      3 | eval();␊
+    `
+
+## no-abusive-eslint-disable - #5
+
+> Snapshot 1
+
+    `␊
+    Error 1/1:␊
+      1 | foo();␊
+    > 2 | 	/* eslint-disable-next-line */␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Specify the rules you want to disable.␊
+      3 | 		eval();␊
+    `
+
+## no-abusive-eslint-disable - #6
+
+> Snapshot 1
+
+    `␊
+    Error 1/1:␊
+    > 1 | // eslint-disable-next-line␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Specify the rules you want to disable.␊
+      2 | eval();␊
+    `

test/utils/visualize-rule-tester.js

@@ -104,7 +104,7 @@ class VisualizeRuleTester {
 
 				const fatalError = messages.find(({fatal}) => fatal);
 				if (fatalError) {
-					throw new Error(fatalError);
+					throw fatalError;
 				}
 
 				const {fixed, output} = fixable ? linter.verifyAndFix(code, verifyConfig) : {fixed: false};