number-literal-case: Refactor to make logic more clear (#834)

sindresorhus · Sep 26, 2020 · e29d7c0 · e29d7c0
1 parent f141d08
commit e29d7c0
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/rules/number-literal-case.js b/rules/number-literal-case.js
@@ -1,14 +1,10 @@
 'use strict';
 const getDocumentationUrl = require('./utils/get-documentation-url');
 
-const fix = (raw, isBigInt) => {
+const fix = raw => {
 	let fixed = raw.toLowerCase();
 	if (fixed.startsWith('0x')) {
 		fixed = '0x' + fixed.slice(2).toUpperCase();
-
-		if (isBigInt) {
-			fixed = fixed.slice(0, -1) + 'n';
-		}
 	}
 
 	return fixed;
@@ -18,14 +14,14 @@ const create = context => {
 	return {
 		Literal: node => {
 			const {value, raw, bigint} = node;
-			const isBigInt = Boolean(bigint);
 
-			if (typeof value !== 'number' && !isBigInt) {
-				return;
+			let fixed = raw;
+			if (typeof value === 'number') {
+				fixed = fix(raw);
+			} else if (bigint) {
+				fixed = fix(raw.slice(0, -1)) + 'n';
 			}
 
-			const fixed = fix(raw, isBigInt);
-
 			if (raw !== fixed) {
 				context.report({
 					node,