Support ESLint v8 #1488
Merged
Support ESLint v8 #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Aug 16, 2021
test/utils/snapshot-rule-tester.mjs
Outdated
| import {codeFrameColumns} from '@babel/code-frame'; | ||
| import outdent from 'outdent'; | ||
| // TODO: Find a better way to test output. |
There was a problem hiding this comment.
46 tasks
# Conflicts: # package.json
Merged
81 tasks
|
ESLint 8 has been released: https://eslint.org/blog/2021/10/eslint-v8.0.0-released |
4 tasks
5 tasks
fregante
reviewed
Oct 11, 2021
| import {codeFrameColumns} from '@babel/code-frame'; | ||
| import outdent from 'outdent'; | ||
|
|
||
| const require = createRequire(import.meta.url); | ||
| const codeFrameColumnsOptions = {linesAbove: Number.POSITIVE_INFINITY, linesBelow: Number.POSITIVE_INFINITY}; | ||
| // A simple version of `SourceCodeFixer.applyFixes` | ||
| // https://github.com/eslint/eslint/issues/14936#issuecomment-906746754 | ||
| const applyFix = (code, {fix}) => `${code.slice(0, fix.range[0])}${fix.text}${code.slice(fix.range[1])}`; |
There was a problem hiding this comment.
It's a lot of noise to concat 3 variables, I'd use
Suggested change
| const applyFix = (code, {fix}) => `${code.slice(0, fix.range[0])}${fix.text}${code.slice(fix.range[1])}`; | |
| const applyFix = (code, {fix}) => code.slice(0, fix.range[0]) + fix.text + code.slice(fix.range[1]); |
51 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1486