Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node.js v12 #1803

Merged
merged 4 commits into from May 1, 2022
Merged

Drop support for Node.js v12 #1803

merged 4 commits into from May 1, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Apr 29, 2022

Enable unicorn/prefer-top-level-await

@fisker fisker marked this pull request as ready for review April 29, 2022 14:36
bmish
bmish approved these changes Apr 29, 2022
View reviewed changes
Copy link
Sponsor Collaborator

@bmish bmish left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps drop Node 12 and update the recommended rules in separate PRs so they show up separately in the changelog?

@sindresorhus sindresorhus merged commit 6f5ecf5 into sindresorhus:main May 1, 2022
@sindresorhus
Copy link
Owner

Perhaps drop Node 12 and enable update the recommended rules in separate PRs so they show up separately in the changelog?

I agree, but not worth blocking this PR for. I'll make sure to note it in the release notes.

@voxpelli voxpelli mentioned this pull request May 4, 2022
Closed
@fisker fisker deleted the nodejs-v14 branch May 5, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @sindresorhus @bmish