Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop checkRequire for prefer-node-protocol #1807

Closed
voxpelli opened this issue May 4, 2022 · 0 comments · Fixed by #1827
Closed

Drop checkRequire for prefer-node-protocol #1807

voxpelli opened this issue May 4, 2022 · 0 comments · Fixed by #1827
Assignees

Comments

@voxpelli
Copy link
Contributor

voxpelli commented May 4, 2022

As a follow up to #1803, which dropped support for Node 12, I want to add this follow up to #1206 as it itself references Node 12 and dropping checkRequire when Node 12 is no longer needed to be supported:

We'll remove this option and check require(…) by default once this feature get backported to v12.

Though erroneously the docs also claim that the node:-protocol is only supported in require(...) for Node 16 and later. It actually is supported in Node ^14.18 || >=16 as @MylesBorins was tweeting and I digged into as a response on Twitter.

Suggestion

  1. Make checkRequire a mandatory part of the rule and remove the option.
  2. Update engines.node in package.json to be ^14.18 || >=16 to indicate this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants