-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer-number-properties
: Don't require by default for Infinity
/-Infinity
to be written as Number.POSITIVE_INFINITY
/Number.NEGATIVE_INFINITY
#2312
Merged
sindresorhus
merged 6 commits into
sindresorhus:main
from
Richienb:disable-checkinfinity
Apr 9, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Number.POSITIVE_INFINITY`/`Number.NEGATIVE_INFINITY` Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Richienb
changed the title
Don't require by default for
Apr 6, 2024
Infinity
/-Infinity
to be written as Number.POSITIVE_INFINITY
/Number.NEGATIVE_INFINITY
prefer-number-properties
: Don't require by default for Infinity
/-Infinity
to be written as Number.POSITIVE_INFINITY
/Number.NEGATIVE_INFINITY
sindresorhus
reviewed
Apr 7, 2024
Anything that changes the lint results is a breaking change. |
CI is failing |
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Not sure what to do about the CI |
May be similar to #2186 (comment) |
4 tasks
sindresorhus
approved these changes
Apr 9, 2024
fisker
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the change, since the option was kept.
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think it's a breaking change
Related to #2311