Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-number-properties: Don't require by default for Infinity/-Infinity to be written as Number.POSITIVE_INFINITY/Number.NEGATIVE_INFINITY #2312

Merged
merged 6 commits into from Apr 9, 2024

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Apr 6, 2024

I don't think it's a breaking change

Related to #2311

…`Number.POSITIVE_INFINITY`/`Number.NEGATIVE_INFINITY`

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb changed the title Don't require by default for Infinity/-Infinity to be written as Number.POSITIVE_INFINITY/Number.NEGATIVE_INFINITY prefer-number-properties: Don't require by default for Infinity/-Infinity to be written as Number.POSITIVE_INFINITY/Number.NEGATIVE_INFINITY Apr 6, 2024
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@sindresorhus
Copy link
Owner

I don't think it's a breaking change

Anything that changes the lint results is a breaking change.

@sindresorhus
Copy link
Owner

CI is failing

@Richienb Richienb marked this pull request as draft April 7, 2024 13:38
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb
Copy link
Contributor Author

Richienb commented Apr 8, 2024

Not sure what to do about the CI

@Richienb Richienb marked this pull request as ready for review April 8, 2024 07:24
@sindresorhus
Copy link
Owner

May be similar to #2186 (comment)

@Richienb Richienb mentioned this pull request Apr 9, 2024
4 tasks
@sindresorhus sindresorhus requested a review from fisker April 9, 2024 08:35
Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change, since the option was kept.

@sindresorhus sindresorhus merged commit e0dfed2 into sindresorhus:main Apr 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants