Add prefer-array-includes rule

[Fabrice-TIERCELIN]

Add prefer-array-includes rule

I didn't write the snapshot test as I don't know how to get the file .js.snap.

Fixes #1058

[yakov116]

Update/create snapshot, use npx ava -u or npx ava test/xxxx.js -u.

Originally posted by @fisker in #1059 (comment)

[fisker]

@Fabrice-TIERCELIN Have you seen this? And we can't copy so many lines from prefer-array-index-of.js, please reuse them.

[Fabrice-TIERCELIN]

Update/create snapshot, use npx ava -u or npx ava test/xxxx.js -u.

Originally posted by @fisker in #1059 (comment)

I will do this.

[fisker]

I really don't understand what are you doing, these two points in this comment #1062 (comment), did you missed or is there something you don't understand?

[Fabrice-TIERCELIN]

I don't have handled this yet.

[Fabrice-TIERCELIN]

OK, so I have looked at prefer-includes. Here is how I see the situation and then you will tell me what you decide to do.

❌No common code: One rule analyzes the inner code of a function and the other rule analyzes the outter code around a function in order that they do not share any code. So they can't be merged. They can only be put together.

❌No big process: Although they produce the same result with the same function includes(), the both rules are independent and unrelated. Let's imagine a case where a rule converts A to B and another rule converts B to C. So let's create a big process that converts A to C. Actually, we have a rule that converts A to C and a rule that converts B to C. So there is no point to merge.

✔️Simpler for the user: It's an "All in one" for the user. So when the user has to select the rules them wants, it's faster and simpler to choose.

You can decide what you want. It's only a point of view. If you want me to merge the rules, I'm OK. It's up to you. Tell me what you want.

[fisker]

Extract code from prefer-array-index-of.js to a function in a shared file, call that function, return selector, listener, messages etc. Use them to create prefer-array-index-of rule.

Call that function with different method and replacement, add selector, listener, messages to prefer-include.

Do the same with tests(we don't even need write new tests, we can use the same one).

[Fabrice-TIERCELIN]

Have you got a good code example?

[fisker]

Do you want me do it? Won't take long.

[Fabrice-TIERCELIN]

Either you give an example, or you do it. As you prefer. It will give me an example for the future features :)

[fisker]

Check #1097

[fisker]

@Fabrice-TIERCELIN Better check commits one by one, you'll understand how it's done.