-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer-string-starts-ends-with
: add suggestions for safely handling non-strings
#1277
Merged
sindresorhus
merged 26 commits into
sindresorhus:main
from
bmish:prefer-string-starts-ends-with-suggestions
May 18, 2021
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
458dfdb
feat: add suggestions for prefer-string-starts-ends-with rule
bmish cf560f6
improve parenthesis logic, use generator function
bmish 1ce3ff3
update suggestion messages
bmish 5e2668b
Merge branch 'main' into prefer-string-starts-ends-with-suggestions
bmish f88404f
switch to correct getParenthesizedText
bmish e9b16d8
handle SequenceExpression with string casting
bmish accc866
should-add-parentheses-to-conditional-expression-child
bmish 285ee93
fix lint
bmish 37f7af0
generate suggestions array
bmish cb5e41d
Refactor
fisker 1bb4725
finish refactor
bmish 4c6e14e
fix comment
bmish f29f8b3
fix lint
bmish 52f3d66
Correct fix logic
fisker 216745a
Add broken test
fisker c1e4502
Fix logic
fisker c593626
More complicated comments test
fisker e931884
Style
fisker 9d8300e
Add parens for `BinaryExpression` too
fisker 4dcdbaf
Merge branch 'main' into prefer-string-starts-ends-with-suggestions
bmish 37ae338
fix lint
bmish 5f48586
Remove suggestions for known `string`s
fisker 4c80e5a
Rename constants
fisker 5ae4507
Update message
fisker c8f72ca
Move throw to top
fisker 3a3d055
Update docs/rules/prefer-string-starts-ends-with.md
bmish File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
rules/utils/should-add-parentheses-to-logical-expression-child.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
'use strict'; | ||
|
||
/** | ||
Check if parentheses should be added to a `node` when it's used as child of `LogicalExpression`. | ||
@param {Node} node - The AST node to check. | ||
@param {{operator: string, property: string}} options - Options | ||
@returns {boolean} | ||
*/ | ||
function shouldAddParenthesesToLogicalExpressionChild(node, {operator, property}) { | ||
/* istanbul ignore next: When operator or property is different, need check `LogicalExpression` operator precedence, not implemented */ | ||
if (operator !== '??' || property !== 'left') { | ||
throw new Error('Not supported.'); | ||
} | ||
|
||
// Not really needed, but more readable | ||
if ( | ||
node.type === 'AwaitExpression' || | ||
node.type === 'BinaryExpression' | ||
) { | ||
return true; | ||
} | ||
|
||
// Lower precedence than `LogicalExpression` | ||
// see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedence#Table | ||
if ( | ||
node.type === 'ConditionalExpression' || | ||
node.type === 'AssignmentExpression' || | ||
node.type === 'AssignmentExpression' || | ||
node.type === 'YieldExpression' || | ||
node.type === 'SequenceExpression' | ||
) { | ||
return true; | ||
} | ||
|
||
return false; | ||
} | ||
|
||
module.exports = shouldAddParenthesesToLogicalExpressionChild; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds extra parenthesis that aren't needed sometimes. I think I had code to handle this before.
in:
(/^b/).test((a))
out:
((a)).startsWith('b')
Not a big deal though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that, but better "add missing parens" instead of "remove extra parens".