Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefer-event-target rule #1792

Merged
merged 14 commits into from May 8, 2022
Merged

Add prefer-event-target rule #1792

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2308764
Add `prefer-event-target` rule
jopemachine Apr 9, 2022
71bfe97
Reflect feedbacks
jopemachine Apr 9, 2022
8c89d6e
Update prefer-event-target.md
jopemachine Apr 12, 2022
8a46b53
Reflect feedbacks
jopemachine Apr 14, 2022
669a52c
Fix lint error
jopemachine Apr 15, 2022
8ee62d2
Fix CI errors
jopemachine Apr 15, 2022
c86161f
Fix misunderstood tests
jopemachine Apr 16, 2022
d15300b
Remove misunderstood selector
jopemachine Apr 16, 2022
8257add
Update prefer-event-target.mjs
jopemachine Apr 28, 2022
035e560
Reflect feedbacks
jopemachine Apr 28, 2022
532fd9b
Consistent style in selector
fisker Apr 28, 2022
1b906ed
Simplify selector
fisker Apr 28, 2022
e1c432d
Fix snapshot
jopemachine Apr 28, 2022
3ec045d
Update prefer-event-target.md
sindresorhus May 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 7 additions & 17 deletions rules/prefer-event-target.js
View file
Open in desktop
Expand Up @@ -6,26 +6,16 @@ const messages = {
[MESSAGE_ID]: 'Prefer `EventTarget` over `EventEmitter`.',
};

const eventEmitterSuperClassSelector = [
matches(['ClassDeclaration', 'ClassExpression']),
'[body.type="ClassBody"]',
' > ',
'Identifier.superClass',
const selector = [
'Identifier',
'[name="EventEmitter"]',
matches([
'ClassDeclaration > .superClass',
'ClassExpression > .superClass',
'NewExpression > .callee',
]),
jopemachine marked this conversation as resolved.
Show resolved Hide resolved
].join('');
jopemachine marked this conversation as resolved.
Show resolved Hide resolved

const newEventEmitterSelector = [
'NewExpression',
' > ',
'Identifier.callee',
'[name="EventEmitter"]',
].join('');

const selector = matches([
eventEmitterSuperClassSelector,
newEventEmitterSelector,
]);

/** @param {import('eslint').Rule.RuleContext} context */
const create = () => ({
[selector](node) {
Expand Down