-
-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use simple selectors #2116
Refactor to use simple selectors #2116
Conversation
|| isMethodCall({ | ||
methods: ['getAttribute', 'removeAttribute', 'hasAttribute'], | ||
argumentsLength: 1 | ||
optionalCall: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why not just make this the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we want ignore optionalCall
check
isMethodCall({
optionalCall: undefined
})
? Odd to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe introduce another flag?
isMethodCall(node, {
checkOptionalCall: false
})
No description provided.