Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of deprecated methods #2173

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Remove use of deprecated methods #2173

merged 1 commit into from
Jul 11, 2023

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jul 11, 2023

@fisker fisker marked this pull request as ready for review July 11, 2023 11:00
@sindresorhus sindresorhus merged commit 980d98b into sindresorhus:main Jul 11, 2023
20 checks passed
@fisker fisker deleted the context-deprecated branch July 11, 2023 16:27
@scrungrth
Copy link

This seems like a breaking change, some of these params were only added recently, requiring a new higher minimum eslint version.

@fisker
Copy link
Collaborator Author

fisker commented Jul 25, 2023

Already required working eslint verison

eslint-plugin-unicorn/package.json

Line 96 in 1b6757e

"eslint": ">=8.44.0"
, released as major https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v48.0.0 what else do you except?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @scrungrth @sindresorhus