Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefer-negative-index rule #417

Merged
merged 32 commits into from Nov 27, 2019
Merged

Add prefer-negative-index rule #417

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
f68080b
Add `prefer-negative-index` rule
fisker Oct 11, 2019
0f2b76c
fix identifier compare
fisker Oct 11, 2019
c9994ed
Merge branch 'master' into rule/prefer-negative-index
fisker Oct 13, 2019
e23be57
rebase
fisker Oct 13, 2019
14390d3
more cases
fisker Oct 16, 2019
391d946
Merge branch 'rule/prefer-negative-index' of github.com:fisker/eslint…
fisker Oct 16, 2019
38a5479
avoid ref issue
fisker Oct 16, 2019
3092586
fix test
fisker Oct 16, 2019
e524d20
disable wrong result
fisker Oct 16, 2019
44acc09
only fix `.length - 1`
fisker Oct 17, 2019
34d7182
handle spacing and parentheses
fisker Oct 17, 2019
79c65b5
disable some eslint rules
fisker Oct 17, 2019
d09006b
remove trimStart
fisker Oct 17, 2019
99827d6
update leadingSpacingLength
fisker Oct 17, 2019
208c512
coverage 100%
fisker Oct 17, 2019
309a870
name test code
fisker Oct 17, 2019
1428526
prototype support
fisker Oct 17, 2019
ff54f48
coverage
fisker Oct 17, 2019
fcae26f
fix function call
fisker Oct 17, 2019
bdf1fc1
style
fisker Oct 17, 2019
25c2704
simplify getMemberName
fisker Oct 17, 2019
bf59ecc
refactor
fisker Oct 17, 2019
0a1c77c
typo
fisker Oct 17, 2019
9706f83
more type
fisker Oct 17, 2019
9950d5d
style
fisker Oct 17, 2019
df6c7b1
code style
fisker Oct 25, 2019
9fae2ef
Merge branch 'master' into rule/prefer-negative-index
sindresorhus Nov 27, 2019
25f5a9d
Update docs/rules/prefer-negative-index.md
fisker Nov 27, 2019
3ea3880
Update docs/rules/prefer-negative-index.md
fisker Nov 27, 2019
f56647d
fix issues
fisker Nov 27, 2019
7f7209f
add comment
fisker Nov 27, 2019
6fee573
update comment
fisker Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions rules/prefer-negative-index.js
View file
Open in desktop
Expand Up @@ -22,6 +22,7 @@ const methods = new Map([
'Float64Array',
'BigInt64Array',
'BigUint64Array'
// {Blob,File}#slice is not used generally
fisker marked this conversation as resolved.
Show resolved Hide resolved
// 'Blob'
// 'File'
fisker marked this conversation as resolved.
Show resolved Hide resolved
])
Expand Down Expand Up @@ -139,8 +140,7 @@ const getRemovalRange = (node, sourceCode) => {
let before = sourceCode.getTokenBefore(node);
let after = sourceCode.getTokenAfter(node);

let start = node.range[0];
let end = node.range[1];
let [start, end] = node.range;

let hasParentheses = true;

Expand Down