Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend fixers for
prefer-string-slice
#424Extend fixers for
prefer-string-slice
#424Changes from all commits
4e71bc2
79c27bb
4ac5039
b8e27a5
cff2a13
3d0d45c
e0a7d6f
bbd45a2
e9736b3
e904cef
7234b60
a06024e
860738c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be an array and concat with
.slice(
and)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to
sliceArguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you rename this variable? more specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be literal zero, we don't want handle
"0"
, utils should have a function do thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text representation of an argument node can only ever be
=== '0'
if it's a literal zero, no?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, my comment is based on
const firstArgument = argumentNodes[0]
(I changed it in my refactoring, but forgot it's not changed here), why we needsourceCode.getText
? Isn'targumentNodes[0]
easier to use?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As almost every branch used the value of
firstArgument
I decided to calculate them in shared space to make the code more easy to read and more DRY.As
firstArgument
then was already calculated I consideredfirstArgument === '0'
to be preferable overisLiteralNumber(argumentNodes[0]) && argumentNodes[0].value === 0
as it's shorter and simpler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for explaining this, this make sense now, but I think it makes the logic little hard to understand. you want use those functions?
eslint-plugin-unicorn/rules/prefer-includes.js
Line 4 in 9e0db0b
eslint-plugin-unicorn/rules/prefer-includes.js
Line 11 in 9e0db0b