Improve lint script #426
Merged
Improve lint script #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakov116
suggested changes
Oct 29, 2019
Co-Authored-By: yakov116 <16872793+yakov116@users.noreply.github.com>
fisker
commented
Oct 29, 2019
yakov116
reviewed
Oct 29, 2019
|
Ready. |
yakov116
suggested changes
Oct 29, 2019
Co-Authored-By: yakov116 <16872793+yakov116@users.noreply.github.com>
fisker
commented
Oct 31, 2019
| - Open a pull request with a title in exactly the format `` Add `rule-name` rule ``, for example, `` Add `no-unused-properties` rule ``. | ||
| - The pull request description should include the issue it fixes, for example, `Fixes #123`. | ||
| - Run `$ npm run lint` to run the rules against codebase to ensure code in the repository are following your rule, _you can ignore this step until your PR is reviewed_. |
There was a problem hiding this comment.
@yakov116 any suggestion?
There was a problem hiding this comment.
Not sure maybe
to run the rules against the codebase. Ensuring that the rest of the codebase follows your rule.
There was a problem hiding this comment.
not rest, new rule self may also not pass, should be all files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
outputFixesandreportwhen there is no error.Add tips for how to fix.