Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom-error-definition to support constructors without a body #442

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
Expand Up @@ -52,6 +52,7 @@
},
"devDependencies": {
"@lubien/fixture-beta-package": "^1.0.0-beta.1",
"@typescript-eslint/parser": "^2.9.0",
"ava": "^2.4.0",
"babel-eslint": "^10.0.3",
"chalk": "^2.4.2",
Expand All @@ -66,6 +67,7 @@
"outdent": "^0.7.0",
"pify": "^4.0.1",
"tempy": "^0.3.0",
"typescript": "^3.7.2",
"xo": "^0.25.3"
},
"peerDependencies": {
Expand Down
6 changes: 6 additions & 0 deletions rules/custom-error-definition.js
Expand Up @@ -80,6 +80,12 @@ const customErrorDefinition = (context, node) => {
}

const constructorBodyNode = constructor.value.body;

// Verify the constructor has a body
if (!constructorBodyNode) {
return;
}

const constructorBody = constructorBodyNode.body;

const superExpression = constructorBody.find(isSuperExpression);
Expand Down
16 changes: 16 additions & 0 deletions test/custom-error-definition.js
Expand Up @@ -12,6 +12,10 @@ const ruleTester = avaRuleTester(test, {
}
});

const typescriptRuleTester = avaRuleTester(test, {
parser: require.resolve('@typescript-eslint/parser')
});

const invalidClassNameError = {ruleId: 'custom-error-definition', message: 'Invalid class name, use `FooError`.'};
const constructorError = {ruleId: 'custom-error-definition', message: 'Add a constructor to your error.'};
const noSuperCallError = {ruleId: 'custom-error-definition', message: 'Missing call to `super()` in constructor.'};
Expand Down Expand Up @@ -433,3 +437,15 @@ ruleTester.run('custom-error-definition', rule, {
}
]
});

typescriptRuleTester.run('custom-error-definition', rule, {
valid: [
outdent`
class CustomError extends Error {
constructor(type: string, text: string, reply?: any);
}
`
],
invalid: [
]
});