Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expiring-todo-comments crashing on invalid package version #494

Merged
merged 1 commit into from Jan 21, 2020
Merged

Fix expiring-todo-comments crashing on invalid package version #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions rules/expiring-todo-comments.js
View file
Open in desktop
Expand Up @@ -159,7 +159,11 @@ function reachedDate(past) {
}

function tryToCoerceVersion(rawVersion) {
let version = rawVersion;
if (!rawVersion) {
return false;
}

let version = String(rawVersion);

// Remove leading things like `^1.0.0`, `>1.0.0`
const leadingNoises = [
Expand Down Expand Up @@ -312,10 +316,10 @@ const create = context => {
const [{condition, version}] = packageVersions;

const packageVersion = tryToCoerceVersion(packageJson.version);
const desidedPackageVersion = tryToCoerceVersion(version);
const decidedPackageVersion = tryToCoerceVersion(version);

const compare = semverComparisonForOperator(condition);
if (compare(packageVersion, desidedPackageVersion)) {
if (packageVersion && compare(packageVersion, decidedPackageVersion)) {
context.report({
node: null,
loc: comment.loc,
Expand Down