Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-node-remove: Only fix when expression is not used #498

Merged
merged 9 commits into from Jan 21, 2020
Merged

prefer-node-remove: Only fix when expression is not used #498

merged 9 commits into from Jan 21, 2020

Commits on Jan 17, 2020

  1. Minor optimizations in prefer-node-append

    @brettz9
    brettz9 committed Jan 17, 2020
    Copy the full SHA
    65e9f46 View commit details
    Browse the repository at this point in the history

  2. Update package-lock.json (bumped upon running per integration tests)

    @brettz9
    brettz9 committed Jan 17, 2020
    Copy the full SHA
    57c0acd View commit details
    Browse the repository at this point in the history

  3. Fix: Do not apply fixer in prefer-node-remove if in a context to se… 

    …t, check, use, or return its return value

`removeChild` returned the removed node, whereas `remove` returns `void`.
    @brettz9
    brettz9 committed Jan 17, 2020
    Copy the full SHA
    b009984 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2020

  1. update per refactoring of @fisker (and apply to prefer-node-append … 

    …file as well)
    @brettz9
    brettz9 committed Jan 19, 2020
    Copy the full SHA
    b1e13f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Implement a isReturnValueUsed utility

    @brettz9
    brettz9 committed Jan 20, 2020
    Copy the full SHA
    be2e063 View commit details
    Browse the repository at this point in the history

  2. Rename utility to isValueUsed

    @brettz9
    brettz9 committed Jan 20, 2020
    Copy the full SHA
    c0ea0b0 View commit details
    Browse the repository at this point in the history

  3. - Invert behavior so naming is accurate

    @brettz9
    brettz9 committed Jan 20, 2020
    Copy the full SHA
    3d36ff6 View commit details
    Browse the repository at this point in the history

  4. Simplifying per @fisker's suggestions

    @brettz9
    brettz9 committed Jan 20, 2020
    Copy the full SHA
    2fb2d22 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. In prefer-node-* methods, avoid fixer when parent is `AssignmentExpre… 

    …ssion`
    @brettz9
    brettz9 committed Jan 21, 2020
    Copy the full SHA
    2e6eefe View commit details
    Browse the repository at this point in the history