Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-object-as-default-parameter rule #633

Merged
merged 13 commits into from Jun 30, 2020
Merged

Add no-object-as-default-parameter rule #633

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
938f32a
Add `disallow-objects-as-default` rule
medusalix Mar 26, 2020
6a89a88
Rename to `no-object-as-default`
medusalix Mar 27, 2020
261becc
Remove `ruleId` from tests
medusalix Jun 6, 2020
d7d1cb2
Update docs
medusalix Jun 28, 2020
a476d85
Update message
medusalix Jun 28, 2020
f3f4b6a
Rename to `no-object-as-default-parameter`
medusalix Jun 28, 2020
b2488cd
Fix default value assignment
medusalix Jun 28, 2020
f23d3cd
Simplify selector
medusalix Jun 28, 2020
64624e7
Add additional tests
medusalix Jun 28, 2020
9871a6b
More tests
fisker Jun 29, 2020
bc2d773
Message test
fisker Jun 29, 2020
538cfee
Format tests
medusalix Jun 29, 2020
c6e325a
Report `node.left` instead of `node`
medusalix Jun 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions rules/no-object-as-default-parameter.js
View file
Open in desktop
Expand Up @@ -4,6 +4,8 @@ const getDocumentationUrl = require('./utils/get-documentation-url');
const MESSAGE_ID = 'noObjectAsDefaultParameter';

const objectParameterSelector = [
':matches(FunctionDeclaration, ArrowFunctionExpression)',
medusalix marked this conversation as resolved.
Show resolved Hide resolved
'>',
'AssignmentPattern',
medusalix marked this conversation as resolved.
Show resolved Hide resolved
'[left.type="Identifier"]',
'[right.type="ObjectExpression"]',
Expand Down
5 changes: 4 additions & 1 deletion test/no-object-as-default-parameter.js
View file
Open in desktop
Expand Up @@ -34,7 +34,10 @@ ruleTester.run('no-object-as-default-parameter', rule, {
'const abc = (foo = \'bar\') => {};',
'const abc = (foo = 123, bar = \'foo\') => {};',
'const abc = (foo = {}) => {};',
'const abc = ({a = true, b = \'foo\'}) => {};'
'const abc = ({a = true, b = \'foo\'}) => {};',
'const {abc = {foo: 1}} = bar;',
'const {abc = {null: \'baz\'}} = bar;',
'const {abc = {foo: undefined}} = undefined;'
],
invalid: [
{
Expand Down