New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-reduce
rule
#704
Merged
Merged
Add no-reduce
rule
#704
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
5690bee
Add docs, tests and empty rules file.
ankeetmaini 64ad5ee
Add more test cases.
ankeetmaini 430e0ec
Add the simplest rule ever.
ankeetmaini 68dc130
Use `medthod-selector` for super tight selections.
ankeetmaini 26818b0
Incorporate review comments. Handle `apply` and min/max args for reduce.
ankeetmaini 88217f1
Skip lint for reduce usages in codebase
ankeetmaini eecc091
Remove `reduce` usages from codebase
ankeetmaini 362b074
Incorporate review comments
ankeetmaini 7f41efb
Remove useless code from tests
ankeetmaini 3b4964b
Add review comment fix
ankeetmaini 409c1ee
Update rules/no-reduce.js
fisker b525aab
Use messageId, simplify selector
fisker 293fb7a
More tests
fisker 394654d
Simplify tests
fisker 866c8b6
Stricter selector
fisker 0182ccf
More tests
fisker 52b9c2b
Remove calls if first arg is a literal or undefined
ankeetmaini 53b4980
Review comments
ankeetmaini 3c52eff
Update test
ankeetmaini be642a5
Add reduceRight
ankeetmaini d32e3f4
Merge branch 'master' into no-reduce
ankeetmaini 6c20b1e
Remove reduceRight from codebase
ankeetmaini f9b75f9
Revert test change
fisker 9a8d249
`notListedMethod` -> `notListed`
fisker dd3f8af
Add `reduceRight` tests and failed tests
fisker db0922f
Fix failed tests
fisker bca2b85
Use different message
fisker 417a37d
Update docs
fisker 6fead63
Tests
fisker 11bc1b7
Tests
fisker 6de1268
Revert cartesian-product-samples.js
fisker c00fe99
Rewrite `reduceRight`
fisker b925b38
Merge branch 'master' into no-reduce
fisker fc2434f
Update no-reduce.md
sindresorhus 17c110c
Update no-reduce.md
sindresorhus File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to loop forward, if you interest https://github.com/fisker/fast-cartesian-product/blob/master/src/algorithms/calculate-from-index.js#L14