Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use singular array element variable name in autofix for no-for-loop rule #745

Merged
merged 6 commits into from May 27, 2020
Merged

Use singular array element variable name in autofix for no-for-loop rule #745

merged 6 commits into from May 27, 2020

Commits on May 27, 2020

  1. feat: use singular array element variable name in autofix for `no-for… 

    …-loop` rule

If the loop is iterating an array with a plural name (such as `plugins`), the generated element variable in the autofix could use the singular version of the array name (`plugin`), instead of just the generic name `element`.
    @bmish
    bmish committed May 27, 2020
    Copy the full SHA
    830b456 View commit details
    Browse the repository at this point in the history

  2. test: refactor test cases for no-for-loop singularization

    @bmish
    bmish committed May 27, 2020
    Copy the full SHA
    f8bcbdb View commit details
    Browse the repository at this point in the history

  3. fix lint

    @bmish
    bmish committed May 27, 2020
    Copy the full SHA
    f0ee389 View commit details
    Browse the repository at this point in the history

  4. add more tests

    @bmish
    bmish committed May 27, 2020
    Copy the full SHA
    26cbca2 View commit details
    Browse the repository at this point in the history

  5. Update rules/no-for-loop.js 

    Co-authored-by: fisker Cheung <lionkay@gmail.com>
    @bmish @fisker
    bmish and fisker committed May 27, 2020
    Copy the full SHA
    4ac535c View commit details
    Browse the repository at this point in the history

  6. fix lint

    @bmish
    bmish committed May 27, 2020
    Copy the full SHA
    3e5ad5d View commit details
    Browse the repository at this point in the history