Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer-starts-ends-with: Fix pipe in regex #783

Merged
merged 3 commits into from Jun 24, 2020
Merged

prefer-starts-ends-with: Fix pipe in regex #783

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9331bb
Failing test to show issue with /A|B/.
Jun 24, 2020
b7dbf4f
Include | in invalid regex chars.
Jun 24, 2020
f3eafb7
Update test/prefer-starts-ends-with.js
fisker Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/prefer-starts-ends-with.js
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ const doesNotContain = (string, characters) => characters.every(character => !st

const isSimpleString = string => doesNotContain(
string,
['^', '$', '+', '[', '{', '(', '\\', '.', '?', '*']
['^', '$', '+', '[', '{', '(', '\\', '.', '?', '*', '|']
);

const regexTestSelector = [
Expand Down
3 changes: 2 additions & 1 deletion test/prefer-starts-ends-with.js
View file
Open in desktop
Expand Up @@ -26,7 +26,8 @@ const validRegex = [
/\^foo/,
/^foo/i,
/^foo/m,
/^foo/im
/^foo/im,
/^A|B/
fisker marked this conversation as resolved.
Show resolved Hide resolved
];

const invalidRegex = [
Expand Down