Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

number-literal-case: Fix false positive on @typescript-eslint/parser #815

Merged
merged 3 commits into from Sep 1, 2020
Merged

number-literal-case: Fix false positive on @typescript-eslint/parser #815

merged 3 commits into from Sep 1, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Sep 1, 2020

Fixes #812

  • Run tests on espree, babel-eslint, @typescript-eslint/parser
  • Add some 0n tests

@hayes
Copy link

hayes commented Sep 1, 2020

thanks for fixing this so quickly!

@fisker fisker mentioned this pull request Sep 1, 2020
Closed
@fisker fisker mentioned this pull request Sep 1, 2020
Merged
@fisker
Copy link
Collaborator Author

fisker commented Sep 1, 2020

This also fix bigint with "numeric separator"

@sindresorhus sindresorhus merged commit 33a1268 into sindresorhus:master Sep 1, 2020
@fisker fisker deleted the ts-number-literal-case branch September 1, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

number-literal-case breaks with bigints
3 participants
@fisker @hayes @sindresorhus