Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test #914

Merged
merged 20 commits into from Dec 7, 2020
Merged

Fix integration test #914

merged 20 commits into from Dec 7, 2020

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 4, 2020

@fisker
Copy link
Collaborator Author

fisker commented Dec 4, 2020

Strange, local test catch that error, but not on CI...

@fisker
Copy link
Collaborator Author

fisker commented Dec 4, 2020

Ah, error is here, didn't fail

@fisker fisker changed the title integration-test: Add fluentui project Fix integration test Dec 4, 2020
@fisker
Copy link
Collaborator Author

fisker commented Dec 4, 2020

Got the error, https://github.com/sindresorhus/eslint-plugin-unicorn/runs/1498259018#step:5:438, but found other problems.

@fisker fisker mentioned this pull request Dec 4, 2020
Merged
@fisker fisker mentioned this pull request Dec 4, 2020
Closed
@sindresorhus
Copy link
Owner

I merged in master, but still failing.

@fisker
Copy link
Collaborator Author

fisker commented Dec 7, 2020 •
edited

Need fix #915 first https://github.com/sindresorhus/eslint-plugin-unicorn/runs/1508474215#step:5:367 Edit: ignored that file, I'll take care of this.

@fisker
Copy link
Collaborator Author

fisker commented Dec 7, 2020 •
edited

This is strange https://github.com/sindresorhus/eslint-plugin-unicorn/pull/914/checks?check_run_id=1510136698#step:5:339, I can't reproduce locally. Will be fixed by #927

@fisker fisker merged commit ca47926 into sindresorhus:master Dec 7, 2020
@fisker fisker deleted the fluentui-test branch December 7, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sindresorhus