Fix error.timedOut not working with execa.sync() (#249)

sindresorhus · May 14, 2019 · 21c706a · Trott · Oct 2, 2019 · ehmicky
1 parent f5172cd
commit 21c706a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -431,7 +431,7 @@ module.exports.sync = (command, args, options) => {
 			code: result.status,
 			joinedCommand,
 			parsed,
-			timedOut: false,
+			timedOut: result.error && result.error.errno === 'ETIMEDOUT',
 			isCanceled: false,
 			killed: result.signal !== null
 		});

diff --git a/test.js b/test.js
@@ -395,6 +395,14 @@ test('timeout kills the process if it times out', async t => {
 	t.true(timedOut);
 });
 
+test('timeout kills the process if it times out, in sync mode', async t => {
+	const {killed, timedOut} = await t.throws(() => {
+		execa.sync('forever', {timeout: 1, message: TIMEOUT_REGEXP});
+	});
+	t.false(killed);
+	t.true(timedOut);
+});
+
 test('timeout does not kill the process if it does not time out', async t => {
 	const {timedOut} = await execa('delay', ['500'], {timeout: 1e8});
 	t.false(timedOut);