Upgrade Codecov #1017
Merged
Upgrade Codecov #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
May 4, 2024
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| flags: '${{ matrix.os }}, node-${{ matrix.node-version }}' |
There was a problem hiding this comment.
Allows filtering test coverage per OS and per Node version in the Codecov UI.
Added |
|
It worked! 👍 It apparently fixed some lines of code which were incorrectly previously marked as not covered. There is only one line of code not covered, which I am looking into now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Codecov to the latest version.
Codecov v4 now requires authenticating with a token. It can be found here under "Repository upload token". It must be added as a secret to this repository (I don't have the permissions to do so).
If this worked correctly, re-running the CI should now show that the test coverage are correctly uploaded. Right now, they show "Error: Codecov token not found. Please provide Codecov token with -t flag.". Please note the job passes even when uploading actually failed.