Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /q option to cmd as well as cmd.exe on Windows #203

Merged
merged 5 commits into from Apr 16, 2019
Merged

Add /q option to cmd as well as cmd.exe on Windows #203

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00c3757
Add the option even when running 'cmd' instead of 'cmd.exe'
GMartigny Apr 8, 2019
3b4ac3d
Safer condition to detect 'cmd'
GMartigny Apr 8, 2019
01084bb
Use optional basename parameter
GMartigny Apr 8, 2019
b2844b9
Add test for running "cmd" command
GMartigny Apr 12, 2019
a624e54
Update test.js
sindresorhus Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion index.js
View file
Open in desktop
Expand Up @@ -60,7 +60,8 @@ function handleArgs(command, args, options) {
options.cleanup = false;
}

if (process.platform === 'win32' && path.basename(command) === 'cmd.exe') {
const basename = path.basename(command);
ehmicky marked this conversation as resolved.
Show resolved Hide resolved
if (process.platform === 'win32' && (basename === 'cmd' || basename === 'cmd.exe')) {
// #116
args.unshift('/q');
}
Expand Down