Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to retry process killing after specified duration #208
Add feature to retry process killing after specified duration #208
Changes from all commits
93b8063
9b8efe9
fcdcaba
3ea8c34
13c3ed1
6bf3aea
90d72a1
856896d
cff5e2f
250498f
fc0d7b2
20e5ecf
d2963e5
f6526aa
91f755d
371df69
702cbf3
a84be97
3cb8dd0
904154a
c6c3873
7b00bbd
83345ad
068fbb6
c2da4d2
61e2491
f024c12
ef944a6
22061ec
c9ddaa6
b9ab61f
785c7cf
6345ca0
d3718d8
141cb53
75fe83c
86fd58f
ed7feb5
fa1502c
7bf47ad
7f9c122
0fca4a1
5615e22
02f5ab1
8fc7179
bb53e7f
50d4219
cb8aacb
756cb78
454f020
4c1af51
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What considerations were given for having 5000 as the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally @zokker13 had it as
2000
. I suggested5000
because I feel like 2 seconds is not enough to do proper shutdown of some processes. E.g. some servers need to perform some network requests before properly closing.But that's an edge case, so this sounds good if you want a much smaller default value. Which one do you have in mind?