Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test for options.preferLocal #216

Merged
merged 2 commits into from May 7, 2019
Merged

Improve test for options.preferLocal #216

merged 2 commits into from May 7, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented May 7, 2019 •
edited

This improves the test for options.preferLocal:

  • makes it work on Windows
  • simplifies it
  • removes cat-names dependency
  • removes test.serial(), i.e. make tests faster

@ehmicky ehmicky requested a review from sindresorhus May 7, 2019 09:57
@sindresorhus sindresorhus merged commit 575d464 into master May 7, 2019
@sindresorhus sindresorhus deleted the feature/preferlocal-test branch May 7, 2019 18:17
@ehmicky ehmicky mentioned this pull request May 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmicky @sindresorhus