Allow transformation of stream output

[ammarbinfaisal1]

I would update the tests and the docs; before that just wanted to ask whether there are anymore built-in transforming options needed?
I hope I understood the issue description correctly

[ehmicky]

Hi @ammarbinfaisal, thanks a lot for the time spent on a new PR since last one (#189)!

Now I am wondering, wouldn't it be more straightforward (and easier to compose) for users to just do the following?

const { stdout } = await execa('echo', ['hello', 'world'])
const value = myTransform(stdout) 

I am asking in the spirit of "keeping it small".

What do you think @ammarbinfaisal and @sindresorhus?

[ammarbinfaisal1]

I guess this would make more sense if the observable support mentioned in #20 is implemented. Unfortunately I've never used observables. btw you'd know better

[ehmicky]

I might be understanding #20 but it seems like it's more about adding support for Observables.

When it comes to transforming the stdout and/or stderr, in buffered mode, this can be done easily at the moment (see code above). In streaming mode, it can also be done easily:

execa('echo', ['hello', 'world']).stdout.pipe(myStreamTransform)

If Observables were implemented, they would come with methods on their own to perform transforms. Or did I misunderstand something?

[ammarbinfaisal1]

So this PR and that issue should be closed?🙄

…

On Tue, 14 May, 2019, 6:59 PM ehmicky ***@***.*** wrote: I might be understanding #20 <#20> but it seems like it's more about adding support for Observables. When it comes to transforming the stdout and/or stderr, in buffered mode, this can be done easily at the moment (see code above). In streaming mode, it can also be done easily: execa('echo', ['hello', 'world']).stdout.pipe(myStreamTransform) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#243?email_source=notifications&email_token=AHMKM7STCNCZV7DXUE7MHGTPVK5EVA5CNFSM4HMZKTAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLPH4A#issuecomment-492237808>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHMKM7V3OQTXUE2YGW72NILPVK5EVANCNFSM4HMZKTAA> .

[ehmicky]

Unless there is something I am not understanding about Observables, I think adding this option might already be easily done. Based on that, I would close this PR.

However I would like to know @sindresorhus opinion on this. Also feel free to let me know where I might be wrong.

[sindresorhus]

Yes, the original intention was for use with Observables.