Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate core options from execa-specific options #256

Merged
merged 4 commits into from May 20, 2019
Merged

Separate core options from execa-specific options #256

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52794ad
Separate core options from execa-specific options
ehmicky May 18, 2019
38c57c6
Fix README header
ehmicky May 20, 2019
cc96aa2
Fix wording
ehmicky May 20, 2019
b186094
Fix wording
ehmicky May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Expand Up @@ -309,9 +309,9 @@ Default: `true`

Set to `false` if you don't want to extend the environment variables when providing the `env` property.

### options from child_process#spawn and child_process#exec
---

The same options as both [`child_process#spawn()`](https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options) and [`child_process#exec()`](https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback) can also be used.
Execa also accepts the below options which are passed directly to [`child_process#spawn()`](https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options)/[`child_process#exec()`](https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I still don't like the wording.

Execa also accepts the below options which are the same as the options for child_process#spawn()/child_process#exec()

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in cc96aa2


#### cwd

Expand Down