Fix Execa crashing when the wrong version of readable-stream
is installed
#259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execa crashes when users have a specific dependency tree installed, which somehow resolves
readable-stream
to the wrong version:This is due to an old version of
readable-stream
being used. This is not an issue for most users, but I managed to trigger this in my own packages.This only happens when
readable-stream@2.2.*
is used instead ofreadable-stream@2.3.*
.readable-stream
is used bymerge-stream
which we use for theall
option.merge-stream
uses the semver range^2.0.1
so this should not be a problem. However I somehow managed to have the wrong version installed inside my dependency tree, probably because of wrong deduping:npm install
or removingpackage-lock.json
does not fixreadable-stream
to the correct version.The good news is that the latest version of
merge-stream
does not usereadable-stream
at all, so that fixes this bug. However that version is not published to npm yet (I have published an issue).