Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unref error #400

Merged
merged 3 commits into from Dec 18, 2019
Merged

Fix unref error #400

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d169fe
Update kill.js
mifi Dec 18, 2019
6ddf015
Update kill.js
mifi Dec 18, 2019
dfaba8e
Update lib/kill.js
mifi Dec 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/kill.js
View file
Open in desktop
Expand Up @@ -18,9 +18,14 @@ const setKillTimeout = (kill, signal, options, killResult) => {
}

const timeout = getForceKillAfterTimeout(options);
setTimeout(() => {
const t = setTimeout(() => {
kill('SIGKILL');
}, timeout).unref();
}, timeout);

// istanbul ignore else
if (t.unref) {
mifi marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehmicky This still needs a code comment about why it's guarded. For example:

Guarded because there's no .unref when execa is used in the renderer process in Electron.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought this was ok to merge, sorry about that.
I've added the comment in #401.

t.unref();
}
};

const shouldForceKill = (signal, {forceKillAfterTimeout}, killResult) => {
Expand Down