Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use strtok3 ESM module (prerelease) #474

Closed
wants to merge 3 commits into from
Closed

Use strtok3 ESM module (prerelease) #474

wants to merge 3 commits into from

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Jul 24, 2021 •
edited

This was referenced Jul 24, 2021
Merged
Merged
@Borewit
Copy link
Collaborator Author

Borewit commented Jul 24, 2021 •
edited

Can you please review my effort moving to ESM @sindresorhus ,

Basically did an attempt to migrate the following dependency tree:
peek-readable ⇒ strtok3 ⇒ file-type

Alpha modules have been released under esm tag in NPM repository.

@sindresorhus
Copy link
Owner

It's failing:

Error: Cannot find module '/home/runner/work/file-type/file-type/node_modules/strtok3/lib/FsPromise' imported from /home/runner/work/file-type/file-type/node_modules/strtok3/lib/index.js

Base automatically changed from esm to main July 24, 2021 21:24
@Borewit Borewit closed this Jul 27, 2021
@Borewit Borewit deleted the strtok3-esm branch July 27, 2021 20:36
@Borewit
Copy link
Collaborator Author

Borewit commented Aug 22, 2021

Superseded by PR #475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
update dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Borewit @sindresorhus