Add support for Apache Parquet #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sindresorhus - hope you're doing well! These test failures don't seem code-related. I had the same issue when running this locally before making any code changes. Is there possibly an upstream issue, like xojs/xo#546? |
sindresorhus
approved these changes
Jan 12, 2023
Borewit
requested changes
Jan 13, 2023
There was a problem hiding this comment.
Code changes are looking good.
@bencmbrook is it possible to use a smaller fixture (without truncating it)?
|
@Borewit yup - good call! Replaced it with a much smaller fixture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #575
Official Documentation (with magic number documented here): https://parquet.apache.org/docs/file-format/