Update type import syntax to fix TS <4.5 compatibility #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support TypeScript below 4.5, see: https://www.typescriptlang.org/docs/handbook/modules.html#importing-types
|
Thanks for the suggestion, but I want to use the |
|
Right, but this is a breaking change that is not clearly documented. Many external projects have not yet migrated to TS 5 however you'd like to put it. And the suggested type import is a feature that, I'm pretty sure, will live on. Not a drastic change, IMO. Regardless, I respect the decision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this module in a monorepo where TypeScript gets resolved to a lower version than v4.5 in some packages. The syntax introduced in v7 is not compatible with these versions. This is a straightforward fix.
See: https://www.typescriptlang.org/docs/handbook/modules.html#importing-types