Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast-glob option suppressErrors is not (entirely) respected #166

Open
starpit opened this issue Jan 7, 2021 · 1 comment
Open

fast-glob option suppressErrors is not (entirely) respected #166

starpit opened this issue Jan 7, 2021 · 1 comment

Comments

@starpit
Copy link

starpit commented Jan 7, 2021

Summary

globby does not entirely respect fast-glob's supressErrors option

Example

require('globby')(['validFile.txt', 'validFile.txt/**/*.txt'], { suppressErrors: true })

Expected output

['validFile.txt']

Actual output

Error: ENOTDIR: not a directory, stat 'validFile.txt/**/*.txt'

This appears to be due to globby's wrapper logic that adds (on top of fast-glob) a call to dir-glob, without obeying the supressErrors option. I realize that this option is part of fast-glob, not dir-glob, but globby's docs specify that fast-glob's options are valid globby options, and, anyway, it'd be nice to do so, I think!

@sindresorhus
Copy link
Owner

Pull request welcome :)

starpit added a commit to starpit/kui that referenced this issue Jan 8, 2021
This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes kubernetes-sigs#6504
starpit added a commit to starpit/kui that referenced this issue Jan 8, 2021
This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes kubernetes-sigs#6504
starpit added a commit to starpit/kui that referenced this issue Jan 8, 2021
This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes kubernetes-sigs#6504
starpit added a commit to starpit/kui that referenced this issue Jan 8, 2021
This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes kubernetes-sigs#6504
starpit added a commit to starpit/kui that referenced this issue Jan 8, 2021
This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes kubernetes-sigs#6504
starpit added a commit to kubernetes-sigs/kui that referenced this issue Jan 8, 2021
This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes #6504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants