Skip to content

Commit

Permalink
Initialize globalResponse regardless of HTTP errors
Browse files Browse the repository at this point in the history
  • Loading branch information
ikorolev93 committed Nov 30, 2020
1 parent 1107cc6 commit b3fba05
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions source/as-promise/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,13 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
return;
}

globalResponse = response;

if (!isResponseOk(response)) {
request._beforeError(new HTTPError(response));
return;
}

globalResponse = response;

resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
});

Expand Down
2 changes: 1 addition & 1 deletion test/promise.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ test('promise.json() can be called before a file stream body is open', withServe
await Promise.all(checks);
});

test.failing('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
test('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
server.get('/', (_request, response) => {
response.statusCode = 400;
response.end('{}');
Expand Down

0 comments on commit b3fba05

Please sign in to comment.