fix: typings for paginate

sindresorhus · Mar 3, 2020 · c98c6a3 · c98c6a3
1 parent 62f3f38
commit c98c6a3
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/source/create.ts b/source/create.ts
@@ -61,9 +61,11 @@ export interface GotRequestMethod {
 	<T>(url: string | Merge<Options, {isStream: true}>, options?: Merge<Options, {isStream: true}>): ProxyStream<T>;
 }
 
+export type GotPaginateOptions<T> = Omit<Options, keyof PaginationOptions<unknown>> & PaginationOptions<T>
+
 export interface GotPaginate {
-	<T>(url: URLOrOptions & PaginationOptions<T>, options?: Options & PaginationOptions<T>): AsyncIterableIterator<T>;
-	all<T>(url: URLOrOptions & PaginationOptions<T>, options?: Options & PaginationOptions<T>): Promise<T[]>;
+	<T>(url: string | GotPaginateOptions<T>, options?: GotPaginateOptions<T>): AsyncIterableIterator<T>;
+	all<T>(url: string | GotPaginateOptions<T>, options?: GotPaginateOptions<T>): Promise<T[]>;
 }
 
 export interface Got extends Record<HTTPAlias, GotRequestMethod>, GotRequestMethod {
@@ -198,8 +200,8 @@ const create = (defaults: Defaults): Got => {
 	}
 
 	// @ts-ignore The missing property is added below
-	got.paginate = async function * <T>(url: URLOrOptions, options?: Options) {
-		let normalizedOptions = normalizeArguments(url, options, defaults);
+	got.paginate = async function * <T>(url: string | Omit<Options, keyof PaginationOptions<unknown>> & PaginationOptions<T>, options?: Omit<Options, keyof PaginationOptions<unknown>> & PaginationOptions<T>) {
+		let normalizedOptions = normalizeArguments(url as URLOrOptions, options as Options, defaults);
 
 		const pagination = normalizedOptions._pagination!;
 
@@ -245,11 +247,11 @@ const create = (defaults: Defaults): Got => {
 		}
 	};
 
-	got.paginate.all = async <T>(url: URLOrOptions, options?: Options) => {
+	got.paginate.all = async <T>(url: string | GotPaginateOptions<T>, options?: GotPaginateOptions<T>) => {
 		const results: T[] = [];
 
-		for await (const item of got.paginate<unknown>(url, options)) {
-			results.push(item as T);
+		for await (const item of got.paginate<T>(url, options)) {
+			results.push(item);
 		}
 
 		return results;